-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make SIP not on by default #73434
make SIP not on by default #73434
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsI'm seeing with SIP the heap size can increase noticeably because we don't compact the SIP regions, for workload that rarely ever does blocking gen2s. so I'm making these not on by default but can be turned on with the GCEnableSpecialRegions config.
|
there are a few methods that are currently compiled for both segments and regions but are only used for segments so made those only compiled for segments. |
@@ -105,6 +105,7 @@ class GCConfigStringHolder | |||
INT_CONFIG (GCTotalPhysicalMemory, "GCTotalPhysicalMemory", NULL, 0, "Specifies what the GC should consider to be total physical memory") \ | |||
INT_CONFIG (GCRegionRange, "GCRegionRange", NULL, 0, "Specifies the range for the GC heap") \ | |||
INT_CONFIG (GCRegionSize, "GCRegionSize", NULL, 4194304, "Specifies the size for a basic GC region") \ | |||
INT_CONFIG (GCEnableSpecialRegions, "GCEnableSpecialRegions", NULL, 0, "Specifies to enable special handling some regions like SIP") \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to document this, or is it only for certain workloads we know would benefit from SIP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now it's just special workloads so I thought I'd leave it as an experimental thing (so not supported in runtimeconfig). we can decide whether to support in runtimeconmfig in the next release when we have experimented with it more. does that sound reasonable?
arm32 failure is due to linked known issue |
I'm seeing with SIP the heap size can increase noticeably because we don't compact the SIP regions, for workload that rarely ever does blocking gen2s. so I'm making these not on by default but can be turned on with the GCEnableSpecialRegions config.