Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SIP not on by default #73434

Merged
merged 2 commits into from
Aug 6, 2022
Merged

make SIP not on by default #73434

merged 2 commits into from
Aug 6, 2022

Conversation

Maoni0
Copy link
Member

@Maoni0 Maoni0 commented Aug 5, 2022

I'm seeing with SIP the heap size can increase noticeably because we don't compact the SIP regions, for workload that rarely ever does blocking gen2s. so I'm making these not on by default but can be turned on with the GCEnableSpecialRegions config.

@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

I'm seeing with SIP the heap size can increase noticeably because we don't compact the SIP regions, for workload that rarely ever does blocking gen2s. so I'm making these not on by default but can be turned on with the GCEnableSpecialRegions config.

Author: Maoni0
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@Maoni0
Copy link
Member Author

Maoni0 commented Aug 5, 2022

there are a few methods that are currently compiled for both segments and regions but are only used for segments so made those only compiled for segments.

src/coreclr/gc/gcpriv.h Outdated Show resolved Hide resolved
src/coreclr/gc/gcpriv.h Outdated Show resolved Hide resolved
@@ -105,6 +105,7 @@ class GCConfigStringHolder
INT_CONFIG (GCTotalPhysicalMemory, "GCTotalPhysicalMemory", NULL, 0, "Specifies what the GC should consider to be total physical memory") \
INT_CONFIG (GCRegionRange, "GCRegionRange", NULL, 0, "Specifies the range for the GC heap") \
INT_CONFIG (GCRegionSize, "GCRegionSize", NULL, 4194304, "Specifies the size for a basic GC region") \
INT_CONFIG (GCEnableSpecialRegions, "GCEnableSpecialRegions", NULL, 0, "Specifies to enable special handling some regions like SIP") \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to document this, or is it only for certain workloads we know would benefit from SIP?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now it's just special workloads so I thought I'd leave it as an experimental thing (so not supported in runtimeconfig). we can decide whether to support in runtimeconmfig in the next release when we have experimented with it more. does that sound reasonable?

@Maoni0
Copy link
Member Author

Maoni0 commented Aug 6, 2022

arm32 failure is due to linked known issue

@Maoni0 Maoni0 merged commit 63b2656 into dotnet:main Aug 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants